Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transcript in output #5

Merged
merged 6 commits into from
Oct 11, 2024
Merged

Transcript in output #5

merged 6 commits into from
Oct 11, 2024

Conversation

jason-raitz
Copy link
Contributor

see AP-271.

If the string "transcript" shows up in an 856 42$y value, then we use that value as the link text and the corresponding $u for the url value. If there are multiple transcripts, it will place a link for each one. Note: if there actually are more than one transcript for a given record, it would be a good practice to disambiguate them in their $y link descriptions.

Copy link
Member

@anarchivist anarchivist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the logic in the view feels a bit heavy - we may want to extend our code in the av-core gem instead to make it easier for us to pull out the data we need than keeping the logic in the view.

app/views/player/_record.html.erb Outdated Show resolved Hide resolved
docker-compose.yml Show resolved Hide resolved
@anarchivist anarchivist merged commit 6f6cf38 into main Oct 11, 2024
8 checks passed
@anarchivist anarchivist deleted the transcript-in-output branch October 11, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants